Skip to content

[D]Network Peers #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[D]Network Peers #174

wants to merge 1 commit into from

Conversation

@michaelkad
Copy link
Collaborator

@michaelkad michaelkad commented Oct 21, 2024

Add [D]: pi_network_peers
Update [D]: pi_network, pi_networks
Update [R]: pi_network

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

=== RUN   TestAccIBMPINetworkPeerOnPrem
--- PASS: TestAccIBMPINetworkPeerOnPrem (43.32s)
PASS

=== RUN   TestAccIBMPINetworksDataSource_basic
--- PASS: TestAccIBMPINetworksDataSource_basic (16.10s)
PASS

=== RUN   TestAccIBMPINetworkPeersDataSourceBasic
--- PASS: TestAccIBMPINetworkPeersDataSourceBasic (15.47s)
PASS

...

Alexander-Kita
Alexander-Kita reviewed Oct 21, 2024
View reviewed changes
Alexander-Kita
Alexander-Kita previously approved these changes Oct 22, 2024
View reviewed changes
ismirlia
ismirlia reviewed Oct 29, 2024
View reviewed changes
ismirlia
ismirlia previously approved these changes Oct 29, 2024
View reviewed changes
Alexander-Kita
Alexander-Kita reviewed Nov 1, 2024
View reviewed changes
Alexander-Kita
Alexander-Kita reviewed Nov 1, 2024
View reviewed changes
Alexander-Kita
Alexander-Kita previously approved these changes Nov 6, 2024
View reviewed changes
ismirlia
ismirlia previously approved these changes Nov 7, 2024
View reviewed changes
@michaelkad michaelkad dismissed stale reviews from ismirlia and Alexander-Kita via 109c22d November 27, 2024 20:15
@michaelkad michaelkad force-pushed the network-peer branch 2 times, most recently from 109c22d to cb5111e Compare December 2, 2024 19:54
@michaelkad
Copy link
Collaborator Author

michaelkad commented Dec 2, 2024 

=== RUN   TestAccIBMPINetworkPeersDataSourceBasic
--- PASS: TestAccIBMPINetworkPeersDataSourceBasic (19.79s)
PASS

=== RUN   TestAccIBMPINetworksDataSource_basic
--- PASS: TestAccIBMPINetworksDataSource_basic (16.51s)
PASS

=== RUN   TestAccIBMPINetworkPeerOnPrem
--- PASS: TestAccIBMPINetworkPeerOnPrem (45.62s)
PASS

ismirlia
ismirlia previously approved these changes Dec 2, 2024
View reviewed changes
Alexander-Kita
Alexander-Kita reviewed Dec 2, 2024
View reviewed changes
@michaelkad
Network Peers
b11c128 
Add [D]: pi_network_peers
Update [D]: pi_network, pi_networks
Update [R]: pi_network
Add require option

Add v1.9.0

fix spacing in cst file
@Alexander-Kita
Copy link
Collaborator

Alexander-Kita commented Dec 3, 2024

Opened in main repo: IBM-Cloud#5835

@yussufsh yussufsh deleted the network-peer branch December 4, 2024 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Alexander-Kita Alexander-Kita Alexander-Kita approved these changes

@ismirlia ismirlia Awaiting requested review from ismirlia

Assignees

No one assigned

Labels

Datasource Q4 Resource

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@michaelkad @Alexander-Kita @ismirlia